Skip to content

Conversation

@SmritiRakuten
Copy link

Description

Describe the changes in this pull request.
Explain your rationale of technical decisions you made (unless discussed before).

Links

Add links to github/jira issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.55466% with 174 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (b055bcb) to head (8f6504a).

Files with missing lines Patch % Lines
js-miniapp-sdk/src/mock-bridge.ts 28.57% 165 Missing ⚠️
js-miniapp-sdk/src/sdkbridge.ts 50.00% 3 Missing and 2 partials ⚠️
js-miniapp-sdk/src/miniapp.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   72.51%   64.30%   -8.21%     
==========================================
  Files          36       37       +1     
  Lines        1055     1300     +245     
  Branches       69      100      +31     
==========================================
+ Hits          765      836      +71     
- Misses        262      434     +172     
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Critical Issues (required ≤ 0)
3 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@rleojoseph
Copy link
Collaborator

Can we fix the build issues @SmritiRakuten ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants