Use run.properties before downloadRepository for getDownloadTypeStatuses#103
Merged
patrick-austin merged 2 commits intomasterfrom Nov 10, 2025
Merged
Use run.properties before downloadRepository for getDownloadTypeStatuses#103patrick-austin merged 2 commits intomasterfrom
patrick-austin merged 2 commits intomasterfrom
Conversation
kevinphippsstfc
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As identified by @louise-davies , it is possible to have a transport mechanism without an entry in the downloadRepository, in which case it is assumed to be enabled with no message defined. In the current implementation, we were getting the list of types to iterate over from the repository, and so missed of any types which were defined in the config but weren't present in the DB.
Instead, use the mappings built from run.properties to iterate over and use defaults for those not defined in the DB.
Modified an existing test to leave out persisting one of the types to test this.