Accept filename FormParam on queue endpoints#70
Merged
patrick-austin merged 2 commits into36_queuingfrom Mar 20, 2025
Merged
Conversation
kevinphippsstfc
requested changes
Mar 19, 2025
| public Response queueVisitId(@FormParam("facilityName") String facilityName, | ||
| @FormParam("sessionId") String sessionId, @FormParam("transport") String transport, | ||
| @FormParam("email") String email, @FormParam("visitId") String visitId) throws TopcatException { | ||
| @FormParam("fileName") String fileName, @FormParam("email") String email, |
There was a problem hiding this comment.
Also need an entry for filename in the method javadoc
| @FormParam("fileName") String fileName, @FormParam("email") String email, | ||
| @FormParam("visitId") String visitId) throws TopcatException { | ||
|
|
||
| logger.info("queueVisitId called"); |
There was a problem hiding this comment.
I think it would be useful to add the visitId to the log message
| public Response queueFiles(@FormParam("facilityName") String facilityName, | ||
| @FormParam("sessionId") String sessionId, @FormParam("transport") String transport, | ||
| @FormParam("email") String email, @FormParam("files") List<String> files) throws TopcatException, UnsupportedEncodingException { | ||
| @FormParam("fileName") String fileName, @FormParam("email") String email, |
There was a problem hiding this comment.
Again fileName needs adding to the javadoc comment
| @FormParam("fileName") String fileName, @FormParam("email") String email, | ||
| @FormParam("files") List<String> files) throws TopcatException, UnsupportedEncodingException { | ||
|
|
||
| logger.info("queueFiles called"); |
There was a problem hiding this comment.
I think it would be useful to report the number of files being queued here eg. "queueFiles called for nnn files"
kevinphippsstfc
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69