Revert separation of polling threads, process queue singly#82
Revert separation of polling threads, process queue singly#82patrick-austin merged 3 commits into36_queuingfrom
Conversation
| queuedDownload.setStatus(DownloadStatus.PREPARING); | ||
| prepareDownload(queuedDownload, null, getQueueSessionId(sessionIds, queuedDownload.getFacilityName())); | ||
| } | ||
| logger.trace("Preparing 1 out of {} queued downloads", queueSize); |
There was a problem hiding this comment.
Unless I'm missing something, I think it would be good to have this at info level. It's only going to be output when a queued item is being moved out of the queue (I think) so it would be useful to be able to trace which bit of logic is taking it out of the queue.
There was a problem hiding this comment.
Yeah when this was trying to start all the Downloads it could (rather than one at a time) we logged before iterating over the list, which may have been empty. Which meant logging even when there was no work to do and we demoted this to trace. Now, because we return early if the list is empty, we only log when there is work to do so can increase this back to info I think.
| prepareDownload(queuedDownload, null, getQueueSessionId(sessionIds, queuedDownload.getFacilityName())); | ||
| } else { | ||
| logger.trace("Preparing up to {} queued downloads", availableDownloads); | ||
| logger.trace("Preparing 1 out of {} queued downloads as {} spaces available", queueSize, availableDownloads); |
There was a problem hiding this comment.
Likewise I think this would be useful at info level
|
I've also made some changes to the |
2 participants
Closes #75