Handle null fileSize SUM, null facilityName, int download_id#83
Merged
patrick-austin merged 1 commit into36_queuingfrom Apr 28, 2025
Merged
Handle null fileSize SUM, null facilityName, int download_id#83patrick-austin merged 1 commit into36_queuingfrom
patrick-austin merged 1 commit into36_queuingfrom
Conversation
kevinphippsstfc
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUM of an empty list returns null, which was causing JSON casting exception. Now check the type, and return
0Lfor thenullcase (an empty dataset should be treated as 0).The default facilityName behaviour only worked for login. For the queue endpoints, it got the default urls OK but then facilityName was still null when it tried to persist the Download, which is not a nullable field. Now, get the default name for that as well as the urls.
The refactored
_expire_downloadformatted the url such thatdownload_idneeded to be a string. This was the case for the direct call, but not option 5 which loads integers from the JSON response. Changed this and other locations to use f-strings, which will handle string or integer arguments gracefully.