Upgrade to JUnit 5

[ajkyffin]

Upgrade from JUnit 4 to 5.

Also upgrades the maven surefire plugin and arquillian components for compatibility.

Fixes the tests on jdk 17/21.

[patrick-austin]

Changes and CI results look good.

Out of interest,, looking at the diff some of the older tests do:

try {
	response = adminResource.getDownloads(facilityName, nonAdminSessionId, null);
	// We should not see the following
	System.out.println("DEBUG: AdminRT.getDownloads response: " + response.getStatus() + ", "
			+ (String) response.getEntity());
	fail("AdminResource.getDownloads did not raise exception for non-admin user");
} catch (ForbiddenException fe) {
	assertTrue(true);
}

The tests I've added recently used ThrowingRunnable, now Executable:

Executable runnable = () -> userResource.queueFiles(facilityName, sessionId, transport, null, email, null);
Throwable throwable = assertThrows(BadRequestException.class, runnable);

Since it felt better to me to use the "official" assert. Just wondered if you had an opinion on which is the best to use going forward?

[ajkyffin]

assertThrows would be better, but there is some debugging output before fail that would be lost it was changed.