Skip to content

Fix misc issues raised by Chris#1700

Merged
louise-davies merged 5 commits intodevelopfrom
chris-issues
Feb 27, 2025
Merged

Fix misc issues raised by Chris#1700
louise-davies merged 5 commits intodevelopfrom
chris-issues

Conversation

@louise-davies
Copy link
Member

@louise-davies louise-davies commented Feb 26, 2025 •
edited
Loading

Description

  • Remove DOI column from DLS Investigation search views
  • When checkboxes are disabled due to parent entity being in the cart, have them checked not unchecked
  • Change "less" to "fewer" in Lucene timeout error text

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@louise-davies louise-davies added enhancement New feature or request datagateway-search Issues relating to the search plugin datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table user feedback Issues that were raised by users labels Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.33%. Comparing base (8707862) to head (472b845).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...way-common/src/views/addToCartButton.component.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1700      +/-   ##
===========================================
- Coverage    95.34%   95.33%   -0.01%     
===========================================
  Files          183      183              
  Lines         7964     7974      +10     
  Branches      2550     2559       +9     
===========================================
+ Hits          7593     7602       +9     
- Misses         334      335       +1     
  Partials        37       37
Flag Coverage Δ
common 94.16% <90.00%> (-0.03%) ⬇️
dataview 97.32% <ø> (ø)
download 96.03% <ø> (ø)
search 93.48% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies merged commit da0c828 into develop Feb 27, 2025
10 checks passed
@louise-davies louise-davies deleted the chris-issues branch February 27, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelvdavies joelvdavies joelvdavies approved these changes

Assignees

No one assigned

Labels

datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table datagateway-search Issues relating to the search plugin enhancement New feature or request user feedback Issues that were raised by users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@louise-davies @joelvdavies