Skip to content

Add examples section to advanced help dialogue#1703

Merged
louise-davies merged 2 commits intodevelopfrom
feature/add-examples-section-advanced-search-help
Mar 7, 2025
Merged

Add examples section to advanced help dialogue#1703
louise-davies merged 2 commits intodevelopfrom
feature/add-examples-section-advanced-search-help

Conversation

@louise-davies
Copy link
Member

@louise-davies louise-davies commented Mar 6, 2025

Description

Adds an example section to the advanced help dialogue. This section appears as the first section, but only if the examples array both exists and has at least 1 example in it.

image

Also fixed that the dialogue title wasn't using the translation string

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@louise-davies louise-davies added the enhancement New feature or request label Mar 6, 2025
@louise-davies louise-davies added the datagateway-search Issues relating to the search plugin label Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (bae84ca) to head (dcb2e1d).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1703   +/-   ##
========================================
  Coverage    95.26%   95.27%           
========================================
  Files          183      183           
  Lines         8010     8014    +4     
  Branches      2569     2578    +9     
========================================
+ Hits          7631     7635    +4     
  Misses         343      343           
  Partials        36       36           
Flag Coverage Δ
common 94.07% <ø> (ø)
dataview 97.31% <ø> (ø)
download 95.86% <ø> (ø)
search 93.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louise-davies louise-davies merged commit 2b26780 into develop Mar 7, 2025
10 checks passed
@louise-davies louise-davies deleted the feature/add-examples-section-advanced-search-help branch March 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datagateway-search Issues relating to the search plugin enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants