Merged
Conversation
increase TextFilter debounce timer to 500ms #1662
Bumps [webpack](https://github.com/webpack/webpack) from 5.76.1 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.76.1...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- also improve datafilePreview e2e tests
…ring Fix default filter on my data DLS table
…dge-max Add max of 999 to viewCartButton
…oveFromCart button
Fix misc issues raised by Chris
…atusTable - also refactor text filters to ensure we don't miss future filter types again
- also improve a11y stuff
- leftovers from pre-ICAT 5 way of doing sizes/counts
…nt fields - then fix unit tests that were filling in those fields
Fix exact filters & add is deleted filter
…tion-advanced-search-help Add examples section to advanced help dialogue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1706 +/- ##
==========================================
- Coverage 95.35% 95.27% -0.09%
==========================================
Files 182 183 +1
Lines 7843 8014 +171
Branches 2490 2574 +84
==========================================
+ Hits 7479 7635 +156
- Misses 329 343 +14
- Partials 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshdimanteto
approved these changes
Mar 10, 2025
Contributor
joshdimanteto
left a comment
joshdimanteto
left a comment
There was a problem hiding this comment.
LGTM (also checked that it runs locally for me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title
As always, only really need to review the last commit (to check the version numbers & changelog looks good) and check that the tests pass, as the release branch is just the
developbranch with the version bump & changelog commit on topTesting instructions
Add a set up instructions describing how the reviewer should test the code