Refresh logic for manufacturers landing page#1460
Open
Conversation
❌ File not in storage
|
MatteoGuarnaccia5
requested changes
Jun 19, 2025
Contributor
MatteoGuarnaccia5
left a comment
MatteoGuarnaccia5
left a comment
There was a problem hiding this comment.
Looks great so far! Just a couple small comments :)
Contributor
There was a problem hiding this comment.
Could you try move the refresh button to have space between the other 2 buttons. It should appear on the far right of the page. Play around with the grids and different flex options
| Refresh | ||
| </Button> | ||
| <Typography data-testid="refresh-timestamp" textAlign={'center'} variant="body1"> | ||
| {formatDateTimeStrings(editRefreshDate.toISOString(), true)} |
Contributor
There was a problem hiding this comment.
Final comment! Just makes it a tad clearer what the actual timestamp is for
Suggested change
| {formatDateTimeStrings(editRefreshDate.toISOString(), true)} | |
| Last refreshed at: {formatDateTimeStrings(editRefreshDate.toISOString(), true)} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refresh button that gives time of last refresh and causes the page to refresh.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1439