Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1717 +/- ##
===========================================
- Coverage 92.98% 92.96% -0.02%
===========================================
Files 13 13
Lines 627 640 +13
Branches 195 199 +4
===========================================
+ Hits 583 595 +12
- Misses 44 45 +1 ☔ View full report in Codecov by Sentry. |
9996181 to
6620090
Compare
6620090 to
692de57
Compare
6e666d3 to
bca3c9f
Compare
d52fda7 to
0ab1735
Compare
7185e01 to
bd50c90
Compare
joelvdavies
reviewed
Mar 9, 2026
Contributor
joelvdavies
left a comment
There was a problem hiding this comment.
Just a couple minor comments/suggestions. Worked well for me and looked good. There is a scrollbar on the items table, due to the new header, but I suspect that will be fixed in the next PR.
src/catalogue/category/catalogueCategoryTableView.component.tsx
Outdated
Show resolved
Hide resolved
575dc36 to
766d5ea
Compare
766d5ea to
d74ee3d
Compare
7 tasks
9de3411 to
89d04e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
see #1656 , #1658
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1656, closes #1658