Skip to content

Update eslint-plugin-react-hooks to 7.0.1 and use shareable config#1742

Open
joelvdavies wants to merge 1 commit intodevelopfrom
use-shareable-eslint-config
Open

Update eslint-plugin-react-hooks to 7.0.1 and use shareable config#1742
joelvdavies wants to merge 1 commit intodevelopfrom
use-shareable-eslint-config

Conversation

@joelvdavies
Copy link
Contributor

Description

Did while reviewing ral-facilities/datagateway#1878. There is alot more shareble config now so used here like Louise did. Also updates react hooks plugin as it was required for one of these (and is for some reason lumped into the React 19 monorepo update by renovate, when its backwards compatible).

There were two rules I had to disable as I cant see a quick fix for them as they are releated to react hook form & uppy usage, both of which have other updates. Other minor changes were one or two missing dependencies, and some state setters that were used prior to the useState which had to be reordered.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (686a86b) to head (180c75c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1742   +/-   ##
========================================
  Coverage    92.98%   92.98%           
========================================
  Files           13       13           
  Lines          627      627           
  Branches       195      180   -15     
========================================
  Hits           583      583           
  Misses          44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies marked this pull request as ready for review March 10, 2026 15:44
Copy link
Contributor

@joshdimanteto joshdimanteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants