Update eslint-plugin-react-hooks to 7.0.1 and use shareable config#1742
Open
joelvdavies wants to merge 1 commit intodevelopfrom
Open
Update eslint-plugin-react-hooks to 7.0.1 and use shareable config#1742joelvdavies wants to merge 1 commit intodevelopfrom
joelvdavies wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1742 +/- ##
========================================
Coverage 92.98% 92.98%
========================================
Files 13 13
Lines 627 627
Branches 195 180 -15
========================================
Hits 583 583
Misses 44 44 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Did while reviewing ral-facilities/datagateway#1878. There is alot more shareble config now so used here like Louise did. Also updates react hooks plugin as it was required for one of these (and is for some reason lumped into the React 19 monorepo update by renovate, when its backwards compatible).
There were two rules I had to disable as I cant see a quick fix for them as they are releated to react hook form & uppy usage, both of which have other updates. Other minor changes were one or two missing dependencies, and some state setters that were used prior to the useState which had to be reordered.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking