Skip to content

Unify styling across all dialog components #1484#1759

Merged
joshdimanteto merged 6 commits intodevelopfrom
unify-styling-across-all-dialog-components-#1484
Mar 17, 2026
Merged

Unify styling across all dialog components #1484#1759
joshdimanteto merged 6 commits intodevelopfrom
unify-styling-across-all-dialog-components-#1484

Conversation

@joshdimanteto
Copy link
Contributor

Description

see #1484 , main focus was on the dialog height and the table views

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

connect to #1484

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.67%. Comparing base (d912045) to head (8841f16).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1759   +/-   ##
========================================
  Coverage    92.67%   92.67%           
========================================
  Files           13       13           
  Lines          642      642           
  Branches       199      200    +1     
========================================
  Hits           595      595           
  Misses          47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshdimanteto joshdimanteto marked this pull request as ready for review March 16, 2026 13:02
@joshdimanteto joshdimanteto linked an issue Mar 16, 2026 that may be closed by this pull request
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made comments on effectively everything I saw that was different or I think might be possible to improve so most are very minor. Generally nicer to use at the larger sizes.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those.

@joshdimanteto joshdimanteto merged commit aa20cf3 into develop Mar 17, 2026
12 of 13 checks passed
@joshdimanteto joshdimanteto deleted the unify-styling-across-all-dialog-components-#1484 branch March 17, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify Styling Across All Dialog Components

2 participants