Open
Conversation
ralexstokes
reviewed
Apr 19, 2024
Owner
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
thanks for this! see comments, I like some of this and generally don't do other parts of it
|
|
||
| let network = config.network; | ||
| info!("configured for `{network}`"); | ||
| tracing::info!("configured for `{network}`"); |
Owner
There was a problem hiding this comment.
generally prefer to import things so there is just a single term at the use site
| @@ -1,7 +1,8 @@ | |||
| pub mod config; | |||
Owner
There was a problem hiding this comment.
I like putting the conditional stuff in its own group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performs small import cleanups.