feat(optimism): optimism support through new feature flag#194
Open
refcell wants to merge 1 commit intoralexstokes:mainfrom
Open
feat(optimism): optimism support through new feature flag#194refcell wants to merge 1 commit intoralexstokes:mainfrom
refcell wants to merge 1 commit intoralexstokes:mainfrom
Conversation
ralexstokes
reviewed
Apr 19, 2024
Owner
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
looks nice, would want to hear more about optimism and pbs
| while let Some(pool_tx) = best_txs.next() { | ||
| if context.is_cancelled() { | ||
| return Ok(()) | ||
| return Ok(()); |
Owner
There was a problem hiding this comment.
I think this is from using stable rustfmt, when this repo has a config file using nightly fmt
| cumulative_gas_used: self.cumulative_gas_used, | ||
| logs: result.logs().into_iter().map(into_reth_log).collect(), | ||
| #[cfg(feature = "optimism")] | ||
| deposit_nonce: None, |
Owner
There was a problem hiding this comment.
very interested in supporting the optimism use case, although I don't know enough about their eco to say what is needed here and what the demand for PBS is
can you point me to resources expounding on these points?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for optimism types in revm and reth with the addition of an
optimismfeature flag.