fix(mev-build-rs): reduce ethers dependency size#195
Open
refcell wants to merge 1 commit intoralexstokes:mainfrom
Open
fix(mev-build-rs): reduce ethers dependency size#195refcell wants to merge 1 commit intoralexstokes:mainfrom
refcell wants to merge 1 commit intoralexstokes:mainfrom
Conversation
ralexstokes
reviewed
Apr 19, 2024
Owner
ralexstokes
left a comment
There was a problem hiding this comment.
thanks for this! I like reducing the scope and would also support a move to alloy rather than ethers
one thing here is that im still in the process of refining the builder machinery so the exact way wallets are used for the builder payment could change
let's revisit once that is more final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces the dependency size primarily in
mev-build-rsusingethers_coreandethers_signerssub-crates instead ofethers. This is in preparation for a port to alloy types - I believe the only blocker here is a wallet for transaction signing (?)