fix(mev-builder-rs): Parallelize Proposer Schedule Relay Querying#203
Open
refcell wants to merge 1 commit intoralexstokes:mainfrom
Open
fix(mev-builder-rs): Parallelize Proposer Schedule Relay Querying#203refcell wants to merge 1 commit intoralexstokes:mainfrom
refcell wants to merge 1 commit intoralexstokes:mainfrom
Conversation
ArtificialPB
reviewed
Dec 2, 2023
| .collect::<FuturesUnordered<_>>(); | ||
|
|
||
| // Stream the schedules for processing via the auction schedule. | ||
| while let Some((i, schedule)) = rx.next().await { |
There was a problem hiding this comment.
tx needs to be dropped after creating tasks and before processing the rx stream, otherwise it will never close since not all senders will be dropped.
ralexstokes
reviewed
Apr 19, 2024
Owner
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
this looks nice! ill keep this in mind to revisit soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses a small
TODOcomment in themev-builder-rscrate to parallelizeProposerSchedulequerying on the relays.