-
Notifications
You must be signed in to change notification settings - Fork 20
[Meson] Split pp_flag into fc_flag and cc_flag #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nimgould Can you confirm that |
|
I believe that __float128 is supported with clang on X86-64 machines, but not otherwise. Otherwise, the only support I know for sure is modern gcc, although there is some suggestion that intel also offer some support (quite what that means, I don't know, as I would have thought that either you do support something or you don't) |
|
Ok thanks Nick! |
|
FWIW I can now compile quad support with clang and static libraries. Also, could you please delay these changes until after #100 has been merged? |
|
I read somewhere earlier that although quad support is offered, many of the intrinsics are converted to double, and thus it is not a true 128 bit offering. But maybe that has changed. I'm sure it will do so eventually, and maybe eventually is now. |
In #100, you drop all macros for the compilation of the C tests (-DINTEGER_64, -DWINDOWS, and the macro for quadruple precision). We only need to remove the flag for preprocessing. |
|
@dpo I am on my way to Argonne but I can take your branch once there and do a rebase + a new release after. |
d81e8c5 to
50447ba
Compare
Sorry, that was certainly not intentional. But it would have been helpful to comment there instead of opening a competing pull request. Anyways, I apologize. |
|
I also didn’t want to compete, I was just very busy yesterday and quickly did some tests between two meetings and a little bit last night. I also added CI tests with the cross-compiler on master, and it was easier to open a PR on top of it. It should be good now, the release 2.5.7 was tagged. |
@nimgould You are right. Earlier, I was compiling locally with x86_64 clang and gfortran and it worked. I just tried with aarm64 clang and gfortran and compilation fails with ../include/cutest.h:64:9: error: __float128 is not supported on this target
64 | typedef __float128 quadreal;All is well with gcc-15. |
No description provided.