-
Notifications
You must be signed in to change notification settings - Fork 10
Update Pay gem dependency to support version 8.3 to < 10.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
710b35f to
c27f504
Compare
|
Any update on this? Using usage_credits is causing Stripe order fulfilment to fail because the old pay gem is locked to Stripe ~>13. |
All good from my side. Tested this in production, it works. Any feedback @rameerez ? |
|
hey @rameerez - any updates? I'm happy to lend a hand if you need some help |
|
Trying to use usage_credits with latest version of Jumpstart Pro and blocked by this too |
|
Before this is merged, you can use this on your Gemfile to use this PR's code gem "usage_credits", github: "kaka-ruto/usage_credits" |
|
thanks @kaka-ruto any tips on how to get around: |
|
in the end I forked it and removed the file |
|
Awesome @njcameron, feel free to send a patch for <=11.2 if it works! |
|
hey @rameerez - could I lend a hand here? we'd love to get this merged for one of our projects |
|
Merged, thanks everyone! The gem lacked proper testing so I added a Minitest test suite (#15) to make sure upgrading Pay didn't break anything in the gem. Added a CI testing matrix too to test against different versions of Pay (#17) to ensure we don't break anything moving forward when adding compatibility for Pay >=10, which has breaking changes. |
|
thanks @rameerez - really appreciate it. lemme know if you ever need a hand here. the gem is super useful, thank you. |
…ameerez#10) Update Pay gem dependency to support versions 8.3 to 9.x
This PR updates the Pay gem dependency to support versions 8.3 and 9,
while maintaining compatibility with existing functionality. The change
modifies the gemspec to specify:
spec.add_dependency "pay", ">= 8.3", "< 10.0"
This allows the usage_credits gem to work with newer versions of the Pay gem
while ensuring compatibility up to but not including version 10.0.