add ackOnMessageError #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigius
requested changes
Nov 5, 2019
README.md
Outdated
| ``` js | ||
| { | ||
| "queue": { // object, required | ||
| "ackOnMessageError": "" // boolean, optional, (send ack when handle funcrion failed, default true) |
Collaborator
There was a problem hiding this comment.
funcrion => function. Also, if its boolean dont set empty string in the esxmaple
| this.emit('message', { type: jsonMessage.type, status: messageStatuses.proceed }); | ||
| } catch (error) { | ||
| this.emit('error', error); | ||
| if (!this.options.ackOnMessageError) throw error; |
Collaborator
There was a problem hiding this comment.
I think its not clear from the name of the variable that you are going to throw an error
Owner
Author
There was a problem hiding this comment.
the error is for cancelling the handling and send the message to sqs again, so queue-router will handle this message again next time
Owner
Author
There was a problem hiding this comment.
in this way i am "sending nack"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.