fix: resolve async issues in robustness tests#12
Merged
ramonclaudio merged 1 commit intomainfrom Sep 6, 2025
Merged
Conversation
- Make detectPackageManager test async to properly await the function - Separate valid string inputs from null/undefined which should throw - Use for...of loops instead of forEach for async operations - Add proper error assertions for invalid inputs - Include all possible return values in assertions Fixes failing fuzz-testing workflow due to unhandled async operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing fuzz-testing workflow due to unhandled async operations.
Problem
The fuzz-testing workflow was failing because:
detectPackageManageris async but tests weren't awaiting it properlynull/undefinedinputs caused file system operations to fail after test completionSolution
detectPackageManagertest async with proper awaitnull/undefinedwhich should throw errorsfor...ofloops instead offorEachfor async operationsTesting
This fix ensures no asynchronous activity leaks after test completion and properly handles both valid and invalid input cases.