fix: use MINISIGN_PASS environment variable for password#18
Closed
ramonclaudio wants to merge 1 commit intomainfrom
Closed
fix: use MINISIGN_PASS environment variable for password#18ramonclaudio wants to merge 1 commit intomainfrom
ramonclaudio wants to merge 1 commit intomainfrom
Conversation
- Add -W flag to all minisign commands to properly read password from stdin - Fixes 'Wrong password for that key' error in publish workflow - Ensures password-protected keys work correctly in CI environment
ramonclaudio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The workflow was failing with "Wrong password for that key" because minisign wasn't properly receiving the password. The previous attempts to pipe the password or use MINISIGN_ASK_PASS don't work.
Solution
Use the
MINISIGN_PASSenvironment variable which minisign checks for the password when running in non-interactive mode. This is the standard way to provide passwords to minisign in CI environments.Changes
MINISIGN_PASSenvironment variable with the password from GitHub secretsTesting
This fix ensures the publish workflow can properly sign artifacts when using password-protected minisign keys stored in GitHub secrets.