Skip to content

fix: use MINISIGN_PASS environment variable for password#19

Merged
ramonclaudio merged 1 commit intomainfrom
fix/minisign-password-handling
Sep 7, 2025
Merged

fix: use MINISIGN_PASS environment variable for password#19
ramonclaudio merged 1 commit intomainfrom
fix/minisign-password-handling

Conversation

@ramonclaudio
Copy link
Owner

Summary

  • Change from piping password to using MINISIGN_PASS env var
  • Remove incorrect MINISIGN_ASK_PASS usage
  • Simplify find command for attestation signing
  • Ensures password-protected keys work correctly in CI

Problem

The workflow was failing with "Wrong password for that key" because minisign wasn't properly receiving the password. The previous attempts to pipe the password or use MINISIGN_ASK_PASS don't work.

Solution

Use the MINISIGN_PASS environment variable which minisign checks for the password when running in non-interactive mode. This is the standard way to provide passwords to minisign in CI environments.

Changes

  • Export MINISIGN_PASS environment variable with the password from GitHub secrets
  • Remove piping attempts and MINISIGN_ASK_PASS usage
  • Simplified the find command for attestation signing

Testing

This fix ensures the publish workflow can properly sign artifacts when using password-protected minisign keys stored in GitHub secrets.

- Change from piping password to using MINISIGN_PASS env var
- Remove incorrect MINISIGN_ASK_PASS usage
- Simplify find command for attestation signing
- Ensures password-protected keys work correctly in CI
@ramonclaudio ramonclaudio merged commit 34a758b into main Sep 7, 2025
5 checks passed
@ramonclaudio ramonclaudio deleted the fix/minisign-password-handling branch September 7, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant