fix: use -W flag for minisign password input from stdin#20
Merged
ramonclaudio merged 1 commit intomainfrom Sep 7, 2025
Merged
Conversation
- Add -W flag to all minisign commands to read password from stdin - Remove MINISIGN_PASS environment variable approach that doesn't work - Pipe password directly to minisign for all signing operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The workflow was failing with "Password: get_password()" error because minisign doesn't recognize the
MINISIGN_PASSenvironment variable. Minisign was waiting for interactive password input which fails in CI.Solution
Use the
-Wflag which tells minisign to read the password from stdin instead of prompting interactively. This allows us to pipe the MINISIGN_PASSPHRASE secret directly to minisign.Changes
-Wflag with piped passwordTesting
This fix ensures the publish workflow can properly sign artifacts when using password-protected minisign keys in CI environments.