Skip to content

update dependencies#539

Merged
ramsayleung merged 1 commit intomasterfrom
ramsay/upgrade-dependencies
Oct 15, 2025
Merged

update dependencies#539
ramsayleung merged 1 commit intomasterfrom
ramsay/upgrade-dependencies

Conversation

@ramsayleung
Copy link
Owner

Description

  1. Update wasm-bindgen-test crate to fix error:
error: unexpected cfg condition name: wasm_bindgen_unstable_test_coverage
    --> src/clients/oauth.rs:1436:5
     |
1436 |     #[wasm_bindgen_test]
     |     ^^^^^^^^^^^^^^^^^^^^
     |
     = help: expected names are: docsrs, feature, and test and 31 more
     = note: using a cfg inside a attribute macro will use the cfgs from the destination crate and not the ones from the defining crate
     = help: try referring to wasm_bindgen_test crate for guidance on how handle this unexpected cfg
     = help: the attribute macro wasm_bindgen_test may come from an old version of the wasm_bindgen_test_macro crate, try updating your dependency with cargo update -p wasm_bindgen_test_macro
     = note: see <[https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html>](https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html%3E) for more information about checking conditional configuration
     = note: -D unexpected-cfgs implied by -D warnings
     = help: to override -D warnings add #[allow(unexpected_cfgs)]
     = note: this error originates in the attribute macro wasm_bindgen_test (in Nightly builds, run with -Z macro-backtrace for more info)
  1. Update getrandom dependencies and change the feature name from js to wasm-js

Motivation and Context

#538 was failing

Dependencies

Nope

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

All the CI tasks pass

Is this change properly documented?

Nope, it's not necessary

@gemini-code-assist
Copy link

Summary of Changes

Hello @ramsayleung, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential dependency updates to ensure the project's continued stability and compatibility. It addresses a critical compilation error by upgrading wasm-bindgen-test and updates the getrandom crate, including a necessary change to its feature flag for WebAssembly targets and an adaptation to its new API, thereby resolving a previously failing CI build.

Highlights

  • wasm-bindgen-test update: Updated wasm-bindgen-test from version "0.3.34" to "0.3.54" to resolve an "unexpected cfg condition" error related to "wasm_bindgen_unstable_test_coverage" that was causing compilation failures.
  • getrandom dependency update: Upgraded the getrandom crate from "0.2.3" to "0.3.4" and adjusted its feature name for wasm32 targets from "js" to "wasm_js" to align with the new version's API.
  • getrandom API usage: Modified the generate_random_string function in src/lib.rs to use "getrandom::fill(&mut buf)" instead of the deprecated "getrandom(&mut buf)" call, reflecting the API changes in the updated getrandom crate.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the wasm-bindgen-test and getrandom dependencies. The update to wasm-bindgen-test resolves a build error with recent Rust nightlies. The getrandom dependency update also involves changing the feature flag for wasm from js to wasm-js and updating the function call from getrandom() to getrandom::fill(). The changes are correct and address the issues described in the pull request. The code modifications are consistent with the API changes in the updated dependencies. Overall, this is a good change to keep the dependencies up-to-date and fix the build.

@ramsayleung ramsayleung merged commit ee0c935 into master Oct 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant