refactor(deps): remove composer/composer package dependency #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composer/composer package dependency was only used to read the contents of the extra section of a project's composer.json file. This commit replaces this logic by standard PHP functions. As a result, the composer/composer dependency has been removed which results in potentially 21 less dependencies when installing this package as a dependency. Closes: ramsey#103
aadmathijssen
force-pushed
the
refactor/remove-composer-package-dependency
branch
from
5cd8fc1 to
589d44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
composer/composerpackage dependency was only used to read the contents of the extra section of a project'scomposer.jsonfile. This commit replaces this logic by standard PHP functions.As a result, the
composer/composerdependency has been removed which results in potentially 21 less dependencies when installing this package as a dependency.Motivation and context
Closes: #103
How has this been tested?
The existing test suite has been updated to reflect the changes.
Types of changes
PR checklist