(fix) charts-build-scripts linter settings#189
Open
alexandreLamarre wants to merge 5 commits intomasterfrom
Open
(fix) charts-build-scripts linter settings#189alexandreLamarre wants to merge 5 commits intomasterfrom
alexandreLamarre wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Alexandre Lamarre <alex7285@gmail.com>
Signed-off-by: Alexandre Lamarre <alex7285@gmail.com>
Signed-off-by: Alexandre Lamarre <alex7285@gmail.com>
Signed-off-by: Alexandre Lamarre <alex7285@gmail.com>
Signed-off-by: Alexandre Lamarre <alex7285@gmail.com>
alexandreLamarre
force-pushed
the
fix-lint
branch
from
dc53168 to
d6b75ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golintis completely frozen and deprecated and should not be usedgolangci-lintwas what was being used before the new team took over, and is what is used mostly in rancher repos / production toolsfixed all the lint issues detected, but you may want to configure stricter rules as those can often expose bugs.