Switch to coder/websocket and make library context aware#59
Open
techknowlogick wants to merge 1 commit intorancher:mainfrom
Open
Switch to coder/websocket and make library context aware#59techknowlogick wants to merge 1 commit intorancher:mainfrom
techknowlogick wants to merge 1 commit intorancher:mainfrom
Conversation
Related PR rancher/remotedialer#147 Note: This contains a replace directive in go.mod due to remoteDialer PR not yet being merged. It should be removed after PR approval, but prior to merging.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This contains a replace directive in go.mod due to remotedialer PR not yet being merged. It should be removed after PR approval, but prior to merging.
cc: @ericpromislow
Issue:
Related PR rancher/remotedialer#147
Problem
Solution
This updates remotedialer-proxy to use the coder/websocket library instead of the gorilla/websocket library due to switch to being context aware and performance improvements, including being more frequently maintained.
CheckList