Open
Conversation
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
brandond
reviewed
Mar 6, 2026
Member
brandond
left a comment
brandond
left a comment
There was a problem hiding this comment.
Is this preferable to removing the hardcoded cluster.local from the default values? That seems like the more correct fix.
Also note that you should bump the packageVersion when changing anything that we modify locally:
https://github.com/rancher/rke2-charts/blob/main-source/packages/rke2-coredns/package.yaml#L2
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
Author
It means the patch is ok ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply global.clusterDomain value only if defined.
Fallback is not needed as default value is already
cluster.localhere