Skip to content

Conversation

@anmazzotti
Copy link
Contributor

What this PR does / why we need it:

This PR fixes a few issues with the golangci-lint v2 migration.
I ran the migrate command to convert the existing config.

Some new rule seem to be added by staticcheck linter, which I fixed.

This PR should replace: #1227

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti added kind/chore area/ci kind/ci Issues or PRs related to CI workflows labels Apr 1, 2025
@anmazzotti anmazzotti self-assigned this Apr 1, 2025
@anmazzotti anmazzotti requested a review from a team as a code owner April 1, 2025 14:24
@anmazzotti anmazzotti moved this to PR to be reviewed in CAPI / Turtles Apr 1, 2025
@anmazzotti anmazzotti force-pushed the bump_golangci-lint branch from c4f62a5 to 25a8cf1 Compare April 1, 2025 14:28
Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti force-pushed the bump_golangci-lint branch from 25a8cf1 to af33f9f Compare April 2, 2025 07:41
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

P.S: we have to do the same migration in CAPI Operator repo where bump is failing: kubernetes-sigs/cluster-api-operator#766 :)

@alexander-demicev alexander-demicev merged commit 279c252 into rancher:main Apr 2, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci kind/chore kind/ci Issues or PRs related to CI workflows

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants