-
Notifications
You must be signed in to change notification settings - Fork 31
[release-v0.24] Bump to v1.33 #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
371455a to
98588a0
Compare
Signed-off-by: Andrea Mazzotti <[email protected]>
98588a0 to
1922354
Compare
|
I don't have a solution for this, so I'm closing the PR. Feel free to follow up if you have ideas. Thank you. |
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
| KUBERNETES_MANAGEMENT_VERSION: "v1.31.4" | ||
| RKE2_VERSION: "v1.31.7+rke2r1" | ||
| KUBERNETES_VERSION: "v1.33.5" | ||
| KUBERNETES_MANAGEMENT_VERSION: "v1.32.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to listwatch problem this will have to stay 1.32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a CAPI problem or provider specific? It would be good to link to existing upstream issue if any or TODO on how to bump it in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's related to WatchList feature and CAAPF, see related PR: rancher/turtles-docs#385
only 1.33 is affected, not 1.32 or 1.34
06e19d9 to
f79de75
Compare
Signed-off-by: Alexandr Demicev <[email protected]>
f79de75 to
9e16b82
Compare
Signed-off-by: Alexandr Demicev <[email protected]>
What this PR does / why we need it:
This is stuck due to the lack of default
WatchListfeature gate in k8s 1.33, which is needed by CAAPF to work.It's enabled by default in 1.32 and 1.34, just not 1.33 for some reason. See reference.
For our tests to work, we need to activate this feature in Kind, however it's not currently supported as an option in the upstream test framework, see: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/framework/bootstrap/kind_provider.go#L43
This will need to be added. See kind docs: https://kind.sigs.k8s.io/docs/user/quick-start/#enable-feature-gates-in-your-cluster
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: