Skip to content

Conversation

@anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Oct 27, 2025

What this PR does / why we need it:
This is stuck due to the lack of default WatchList feature gate in k8s 1.33, which is needed by CAAPF to work.
It's enabled by default in 1.32 and 1.34, just not 1.33 for some reason. See reference.

For our tests to work, we need to activate this feature in Kind, however it's not currently supported as an option in the upstream test framework, see: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/framework/bootstrap/kind_provider.go#L43

This will need to be added. See kind docs: https://kind.sigs.k8s.io/docs/user/quick-start/#enable-feature-gates-in-your-cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti self-assigned this Oct 27, 2025
@anmazzotti anmazzotti moved this to In Progress (8 max) in CAPI / Turtles Oct 27, 2025
@anmazzotti anmazzotti changed the base branch from main to release-0.24 October 27, 2025 12:51
@anmazzotti anmazzotti force-pushed the v0-24_bump_k8s_v1-33 branch from 371455a to 98588a0 Compare October 27, 2025 13:05
Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti force-pushed the v0-24_bump_k8s_v1-33 branch from 98588a0 to 1922354 Compare October 27, 2025 14:27
@anmazzotti anmazzotti moved this from In Progress (8 max) to Blocked in CAPI / Turtles Oct 29, 2025
@anmazzotti
Copy link
Contributor Author

I don't have a solution for this, so I'm closing the PR. Feel free to follow up if you have ideas. Thank you.

@anmazzotti anmazzotti closed this Oct 31, 2025
@github-project-automation github-project-automation bot moved this from Blocked to Done in CAPI / Turtles Oct 31, 2025
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev alexander-demicev changed the title V0 24 bump k8s v1 33 [release-v0.24] Bump to v1.33 Nov 5, 2025
@alexander-demicev
Copy link
Member

KUBERNETES_MANAGEMENT_VERSION: "v1.31.4"
RKE2_VERSION: "v1.31.7+rke2r1"
KUBERNETES_VERSION: "v1.33.5"
KUBERNETES_MANAGEMENT_VERSION: "v1.32.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to listwatch problem this will have to stay 1.32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a CAPI problem or provider specific? It would be good to link to existing upstream issue if any or TODO on how to bump it in the future

Copy link
Contributor Author

@anmazzotti anmazzotti Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's related to WatchList feature and CAAPF, see related PR: rancher/turtles-docs#385

only 1.33 is affected, not 1.32 or 1.34

@alexander-demicev alexander-demicev marked this pull request as ready for review November 5, 2025 15:18
@alexander-demicev alexander-demicev requested a review from a team as a code owner November 5, 2025 15:18
@alexander-demicev alexander-demicev moved this from Done to PR to be reviewed in CAPI / Turtles Nov 5, 2025
@alexander-demicev alexander-demicev force-pushed the v0-24_bump_k8s_v1-33 branch 2 times, most recently from 06e19d9 to f79de75 Compare November 5, 2025 16:57
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev alexander-demicev merged commit f98e8b5 into release-0.24 Nov 6, 2025
5 checks passed
@alexander-demicev alexander-demicev deleted the v0-24_bump_k8s_v1-33 branch November 6, 2025 12:06
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants