Skip to content

GATT notifications : use setCharacteristicNotification from Android 4.3 #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GATT notifications : use setCharacteristicNotification from Android 4.3 #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87fb99
Fix issue #294 - call setCharacteristicNotification when subscribe to…
fmhun Jul 11, 2016
1b9bb24
Handle setCharacteristicNotification error, remove sdk target check.
fmhun Jul 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/android/BluetoothLePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,15 @@ private boolean subscribeAction(JSONArray args, CallbackContext callbackContext)
return false;
}

result = bluetoothGatt.setCharacteristicNotification(characteristic, true);

if (!result) {
addProperty(returnObj, keyError, errorSubscription);
addProperty(returnObj, keyMessage, logSubscribeFail);
callbackContext.error(returnObj);
return false;
}

AddCallback(characteristicUuid, connection, operationSubscribe, callbackContext);

//Write the descriptor value
Expand Down Expand Up @@ -1856,6 +1865,15 @@ private boolean unsubscribeAction(JSONArray args, CallbackContext callbackContex
return false;
}

result = bluetoothGatt.setCharacteristicNotification(characteristic, false);

if (!result) {
addProperty(returnObj, keyError, errorSubscription);
addProperty(returnObj, keyMessage, logSubscribeFail);
callbackContext.error(returnObj);
return false;
}

AddCallback(characteristicUuid, connection, operationUnsubscribe, callbackContext);

//Write the actual descriptor value
Expand Down