Fix symbol class handling for rendering and broadcasting#80
Open
ayezutov wants to merge 1 commit intorandomBrainstormer:mainfrom
Open
Fix symbol class handling for rendering and broadcasting#80ayezutov wants to merge 1 commit intorandomBrainstormer:mainfrom
ayezutov wants to merge 1 commit intorandomBrainstormer:mainfrom
Conversation
|
Unfortunately this did absolutely nothing to get my symbols to show up in MMM-CalendarExt3. event color gets passed through fine, but not symbols for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to setup a dashboard with MMM-CalendarExt3 and MMM-CalendarExt3Journal. When doing so I could not make the symbols to work. Upon diving deep I have realized that there are some peculiarities about how symbol classes and symbols are being handled.
calendarIDwas not stored on the event in the eventList. This led to always showing the default icon for the module ('calendar'). I have updated line 1072 to explicitly setcalendarIDon the cloned event. This should be safe as it is removed in line 1076 either way.symbolClassto mimic the native's calendar format.