Skip to content

Conversation

@randy408
Copy link
Owner

Fixes #4

endif
else # Using fallback
if can_apply_patch == false
warning(meson_too_old_msg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an error?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you really wanted to make it work using an older version you could apply it manually and there's no point in preventing that. Both uses of meson_too_old_msg should the same (both warning() or error()) but I haven't decided yet.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, which should it be, warning or error?

Keen to see this PR merged

@FN-FAL113
Copy link

hopefully waiting for this

@svgeesus
Copy link

@Tachi107 @randy408 what can be done to get this PR reviewed and merged?

@randy408
Copy link
Owner Author

I'm still working out some internal details before I push code to this branch, shortly after I will be making another PR for encode support, that one will go much quicker.

@svgeesus
Copy link

Great, thanks for the update.

I'm wanting to make some utilities which generate specific PNG files, including APNG, to use in testing. I can use apngasm for some of it, but that doesn't give me the low-level control I need. Hence my interest.

@sturkmen72
Copy link

@randy408 let me know any help needed about this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Animated PNG (APNG) read support

6 participants