Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of memgraph in transpiler is reasonably far along.
The remaining issue is that there a bunch of tests that don't pass. And not only don't pass, but cause memgraph to crash. I've logged a bug with memgraph here:
memgraph/memgraph#3080
Since bringing down memgraph pretty much guarantees that every test after that fails, I was disabling tests to try to let others run, (by putting "x" in front of the test name) but I eventually 1) didn't uncover any other problems and 2) got tired of this, so I am stopping for now.
I'll give memgraph a little time to see how they respond to the bug and if it looks like a fix is not forthcoming, I'll take a look at rewriting the path collection part.