Skip to content

Fix IME preedit overlay and add tests#1434

Open
Tryanks wants to merge 1 commit intoraphamorim:mainfrom
Tryanks:fix/preedit-overlay
Open

Fix IME preedit overlay and add tests#1434
Tryanks wants to merge 1 commit intoraphamorim:mainfrom
Tryanks:fix/preedit-overlay

Conversation

@Tryanks
Copy link
Copy Markdown

@Tryanks Tryanks commented Feb 3, 2026

before

before

after

after

@Tryanks Tryanks force-pushed the fix/preedit-overlay branch from 64e1a2d to 5304252 Compare February 3, 2026 07:53
@JRBros2346
Copy link
Copy Markdown
Contributor

Run cargo fmt and push changes. It must make the Checks to pass

@Tryanks Tryanks force-pushed the fix/preedit-overlay branch from 5304252 to 481577f Compare February 3, 2026 08:25
@u1-liquid
Copy link
Copy Markdown

The current CI failure appears to be caused by an external factor rather than this change.
If this fix is merged, it will significantly improve usability for CJK users, so it would be very helpful if the priority could be raised.

At the moment, the IME pre-edit text is not rendered at all, and users sometimes have to rely on a popup that is completely misaligned to input text. This makes typing quite inconvenient for CJK users.

@JRBros2346
Copy link
Copy Markdown
Contributor

The current CI failure appears to be caused by an external factor rather than this change.

Yup. For some reason, the windows CI often gets stuck and gets auto cancelled after 6h. All the other CI's are passed tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants