feat: add multiple shell profiles support#1443
Open
OleksandrKucherenko wants to merge 10 commits intoraphamorim:mainfrom
Open
feat: add multiple shell profiles support#1443OleksandrKucherenko wants to merge 10 commits intoraphamorim:mainfrom
OleksandrKucherenko wants to merge 10 commits intoraphamorim:mainfrom
Conversation
Implements raphamorim#622 - Multiple configuration profiles and selector This adds support for defining multiple shell profiles and a quick selector to switch between them when creating new tabs. ## Configuration - `[shell]` - Default shell (unchanged behavior) - `[[shells]]` - Array of additional shell profiles with optional name ## Keybindings - `Ctrl+Shift+T` / `Cmd+T`: Create tab with default shell (unchanged) - `Ctrl+Shift+Y` / `Cmd+Y`: Open shell profile selector overlay ## Profile Selector - Navigate with j/k or arrow keys - Press 1-9 to directly select a profile - Press Enter to confirm, Escape to cancel ## Example config: ```toml [shell] program = "pwsh" args = [] [[shells]] name = "WSL" program = "C:\\Windows\\System32\\wsl.exe" args = [] [[shells]] name = "CMD" program = "C:\\Windows\\System32\\cmd.exe" args = [] ``` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing shells field in ContextManagerConfig - Fix border_radius type (f32 -> [f32; 4])
- Remove unused `shells` field from ContextManagerConfig (was stored but never read) - Update shell_selector when config is hot-reloaded (allows dynamic shell list changes) - Refactor tests to use create_dead_context instead of create_context - This prevents forking ~40+ real shell processes during tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Summary
This PR adds support for multiple shell profiles in Rio terminal, allowing users to:
[shell](existing behavior)[[shells]]arrayCtrl+Shift+Tto create tabs with the default profile (unchanged)Ctrl+Shift+Yto open a profile selector to choose which shell to useConfiguration Example
Profile Selector
When you press
Ctrl+Shift+Y(orCmd+Yon macOS), a selector overlay appears:j/kor arrow keys to navigate1-9to directly select a profileEnterto confirm selectionEscapeto cancelChanges
Shellstruct with optionalnamefieldshells: Vec<Shell>field toConfigShellProfileSelectoraction with keybindingShellSelectorstate module for managing selector UIcreate_tab_with_shell()method for creating tabs with specific shellsTesting
Ctrl+Shift+Yto open selector🤖 Generated with Claude Code