-
Notifications
You must be signed in to change notification settings - Fork 52
Added/Updated PR templates #3673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
joneill-r7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we default to use core.md as the default as we're more common to open PRs and then for any public contributions we could link the other template?
I wonder should be more a mirror of each in ordering / titles, but with the public template having the extra sections?
9efcb83 to
4399228
Compare
joneill-r7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - just one minor
bb7f0e6 to
3ff3692
Compare
Description
Currently, we have same Github PR template for core backend and third party contributors. In terms of working with the plugins and creating PRs, it feels a little bit noisy for core team.
In that case, separate template was created as well as current third party template was updated. To choose the core template you need to add the following to the URL when creating a pull request on Github:
To check for the templates just view those files on Github, so that they will be formatted using GH Markdown