Open
Conversation
|
Thanks for your pull request! As part of our landing process, we manually verify that all modules work as expected. We've added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #20790 adding
Msf::OptTimedeltaas a reusable datastore option with built-in validation and normalization to seconds, so modules don’t need custom regex or manual conversions. It supports signed and compound durations (e.g.-5m,1h30m,2d). Kerberos-specific clock skew parsing has been removed, and all Kerberos consumers now useOptTimedeltadirectly, ensuring a single shared parsing path across the framework.Note: I think lib/msf/core/exploit/remote/kerberos/clock_skew.rb is no longer need, can be deleted.
Verification
bundle exec rake db:create db:migrate db:seed RAILS_ENV=testbundle exec rspec spec/lib/msf/core/opt_timedelta_spec.rb spec/lib/msf/core/exploit/remote/kerberos/client_spec.rbmsfconsoleuse auxiliary/scanner/smb/smb_login