Specify YAML coder for mdm payload #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwelch-r7
force-pushed
the
add-coder-to-mdm-payload
branch
3 times, most recently
from
dea65af to
e4cdb04
Compare
cgranleese-r7
approved these changes
Mar 21, 2025
adfoster-r7
reviewed
Mar 21, 2025
adfoster-r7
reviewed
Mar 21, 2025
dwelch-r7
force-pushed
the
add-coder-to-mdm-payload
branch
from
e4cdb04 to
b5f7406
Compare
dwelch-r7
commented
Mar 21, 2025
|
|
||
| class Event < ApplicationRecord | ||
| serialize :info | ||
| if ActiveRecord::VERSION::MAJOR >= 7 && ActiveRecord::VERSION::MINOR >= 1 |
Contributor
Author
There was a problem hiding this comment.
we're tab indented here for some reason, ignore the formatting it looks normal in the IDE, file was orinigally tabs so not going to change that
dwelch-r7
force-pushed
the
add-coder-to-mdm-payload
branch
2 times, most recently
from
f8efb0a to
86e1602
Compare
dwelch-r7
force-pushed
the
add-coder-to-mdm-payload
branch
from
86e1602 to
8458eea
Compare
dwelch-r7
force-pushed
the
add-coder-to-mdm-payload
branch
from
8458eea to
cb882a2
Compare
dwelch-r7
commented
Mar 21, 2025
Comment on lines
+96
to
+100
| if ActiveRecord::VERSION::MAJOR >= 7 && ActiveRecord::VERSION::MINOR >= 1 | ||
| serialize :urls, coder: YAML | ||
| else | ||
| serialize :urls | ||
| end |
Contributor
Author
There was a problem hiding this comment.
since specifying coder: is a noop, and the old code didn't specify any coder, this if/else statementi s kind of redundant, I did add in an explicit serialize :urls, YAML but that broke the tests and it makes more sense to keep the old functionality the same as it was before
I don't mind keeping it here, since it makes it obvious what the intention is
adfoster-r7
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to specify a coder here to be compatible with Rails 7.1
Tested as part of the framework PR rails 7.1 here: rapid7/metasploit-framework#19953
Rails 7.0 here: rapid7/metasploit-framework#19977