Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes code that writes to the PollStats model as part of migrating to the newer PollStatsCounter model for tracking poll statistics. The changes are focused on removing write operations while preserving the existing PollStatsCounter functionality.
Key Changes:
- Removed
PollStatsobject creation and bulk insertion from poll results counting logic - Removed
PollStatsdeletion logic from thedelete_poll_statsmethod - Removed the unused
get_question_statsclassmethod from thePollStatsmodel - Updated test assertions to remove
PollStatschecks while keepingPollStatsCounterchecks
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ureport/stats/models.py | Removed the unused get_question_stats classmethod that filtered PollStats objects |
| ureport/polls/models.py | Removed PollStats import, object creation, bulk insert, and deletion logic from poll statistics methods |
| ureport/polls/tests.py | Removed PollStats assertions from test_delete_poll_stats and test_poll_results_stats while preserving PollStatsCounter test coverage |
| ureport/public/tests.py | Removed extraneous blank line for code cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1324 +/- ##
==========================================
+ Coverage 83.79% 83.82% +0.02%
==========================================
Files 49 49
Lines 6066 6051 -15
==========================================
- Hits 5083 5072 -11
+ Misses 983 979 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.