Remove old branding

[norkans7]

No description provided.

[Copilot]

Pull request overview

This pull request removes legacy branding configuration options and consolidates all organizations to use the new 2024 UNICEF brand. The changes eliminate customizable color schemes and brand flags, replacing them with a standardized color palette and logo system.

Changes:

• Removed 8 legacy branding configuration fields (dark1_color, dark2_color, dark3_color, light1_color, light2_color, colors, colors_map, and has_new_brand)
• Replaced all dynamic color references in templates with hardcoded 2024 brand colors
• Updated default color values in the PollQuestion model to match the new brand palette
• Removed conditional branding logic from templates and context processors
• Cleaned up the org_color template filter and related test code

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ureport/settings_common.py	Removed 8 organization configuration fields for custom branding
ureport/public/tests.py	Updated test assertion to reflect reduced number of form fields (71 → 63)
ureport/public/context_processors.py	Removed is_new_brand and colors_map from context
ureport/polls/tests.py	Removed tests for the deleted org_color template filter and updated show_org_flags test calls
ureport/polls/templatetags/ureport.py	Removed org_color template filter and is_new_brand from show_org_flags context
ureport/polls/models.py	Updated default color values in QUESTION_COLOR_CHOICE_BG_COLORS to new brand colors
templates/public_base.html	Replaced dynamic color template tags with hardcoded 2024 brand colors and removed conditional branding logic
templates/public/ureporters.html	Replaced conditional color logic with hardcoded #00aeef
templates/public/polls.html	Removed conditional color cycling logic and standardized to #00aeef and bg-dark1-v2024
templates/public/org_flags.html	Removed conditional branding logic, keeping only the new brand dropdown
templates/public/join_engage.html	Removed conditional branding from circle styling
templates/public/index.html	Removed conditional branding and logo selection logic
templates/frame.html	Standardized favicon to new 2024 version with improved formatting
templates/base_admin_dashboard.html	Updated admin dashboard colors and removed conditional branding, added org name display unconditionally

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The color naming is misleading. 'D1' is labeled 'Dark 1' but uses '#98DFF9' (a light cyan/blue), while 'L1' is labeled 'Light 1' but uses '#143E49' (a dark blue). This creates confusion between the semantic names and actual color values. Consider either updating the labels in QUESTION_COLOR_CHOICES to match the actual color characteristics, or adjusting the colors to match their semantic labels.

[Copilot]

While adding a comment for the favicon is good practice, this formatting change adds extra lines where the original code was more compact. Consider maintaining consistency with the rest of the codebase's formatting style.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (49fba87) to head (ff8c569).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   83.82%   83.72%   -0.10%     
==========================================
  Files          49       49              
  Lines        6051     6017      -34     
==========================================
- Hits         5072     5038      -34     
  Misses        979      979              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.