-
Notifications
You must be signed in to change notification settings - Fork 990
Filter row groups using byte range in the new experimental parquet reader #20733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 11 commits into
rapidsai:main
from
mhaseeb123:fea/hybrid-scan-filter-row-groups-with-byte-ranges
Dec 3, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
558386b
Filter row groups with byte range in hybrid scan reader
mhaseeb123 c8b73a2
Update API
mhaseeb123 bb58fc4
Update doc
mhaseeb123 3159064
Merge branch 'main' into fea/hybrid-scan-filter-row-groups-with-byte-…
mhaseeb123 cafde09
Apply suggestions from code review
mhaseeb123 103d53e
Apply suggestions from code review
mhaseeb123 abcc2b6
Merge branch 'main' into fea/hybrid-scan-filter-row-groups-with-byte-…
mhaseeb123 8ba39e5
Add comments
da15824
minor stuff
2d29027
style fix
4c0b6a4
Merge branch 'main' of https://github.com/rapidsai/cudf into fea/hybr…
mhaseeb123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,6 +74,18 @@ size_type hybrid_scan_reader::total_rows_in_row_groups( | |
| return _impl->total_rows_in_row_groups(input_row_group_indices); | ||
| } | ||
|
|
||
| std::vector<size_type> hybrid_scan_reader::filter_row_groups_with_byte_range( | ||
| cudf::host_span<size_type const> row_group_indices, parquet_reader_options const& options) const | ||
| { | ||
| CUDF_FUNC_RANGE(); | ||
|
|
||
| // Temporary vector with row group indices from the first source | ||
| auto const input_row_group_indices = | ||
| std::vector<std::vector<size_type>>{{row_group_indices.begin(), row_group_indices.end()}}; | ||
|
|
||
| return _impl->filter_row_groups_with_byte_range(input_row_group_indices, options).front(); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Call the impl API |
||
| } | ||
|
|
||
| std::vector<cudf::size_type> hybrid_scan_reader::filter_row_groups_with_stats( | ||
| cudf::host_span<size_type const> row_group_indices, | ||
| parquet_reader_options const& options, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaseeb123 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New public API