Skip to content

Deprecate nvtext::edit_distance_matrix API #21159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidwendt wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Deprecate nvtext::edit_distance_matrix API #21159

davidwendt wants to merge 10 commits into from
+23 −75

Conversation

@davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jan 23, 2026

Description

Deprecates the nvtext::edit_distance_matrix() API for removal in a future release.
This API is not being used by any of the RAPIDS or NeMo libraries.
The regular nvtext::edit_distance() function will remain and continues to be updated.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Jan 23, 2026
@davidwendt davidwendt requested review from a team as code owners January 23, 2026 18:01
@davidwendt davidwendt added the 3 - Ready for Review Ready for review by team label Jan 23, 2026
@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function labels Jan 23, 2026
@davidwendt davidwendt added the breaking Breaking change label Jan 23, 2026
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jan 23, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Jan 23, 2026
mroeschke
mroeschke reviewed Jan 23, 2026
View reviewed changes
PointKernel
PointKernel reviewed Jan 26, 2026
View reviewed changes
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 27, 2026 18:37
@KyleFromNVIDIA
Copy link
Member

KyleFromNVIDIA commented Jan 27, 2026

Includes changes from #21196

@KyleFromNVIDIA KyleFromNVIDIA added the 0 - Blocked Cannot progress due to external reasons label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@PointKernel PointKernel PointKernel approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@Matt711 Matt711

@davidwendt davidwendt

@KyleFromNVIDIA KyleFromNVIDIA

Labels

0 - Blocked Cannot progress due to external reasons 3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API. strings strings issues (C++ and Python)

Projects

cuDF Python
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidwendt @KyleFromNVIDIA @mroeschke @PointKernel @Matt711