Skip to content

Conversation

@vuule
Copy link
Contributor

@vuule vuule commented Jan 27, 2026

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@res-life
Copy link
Contributor

What's the perf impact of disabling multi-thread, do we have a number?

@vuule
Copy link
Contributor Author

vuule commented Jan 28, 2026

What's the perf impact of disabling multi-thread, do we have a number?

This optimization was added as part of #20996. I measured 30% improvement in our benchmarks when all columns are strings columns.

I think it's better to revert it and implement it more carefully/early in a future release, we are already deep in code freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libcudf Affects libcudf (C++/CUDA) code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants