Skip to content

Use ColumnBase.create in from_arrow, follow-ups in pyarrow 19 decimal support #21317

Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
mroeschke:ref/cudf/decimal_simplfiy
Feb 6, 2026
Merged

Use ColumnBase.create in from_arrow, follow-ups in pyarrow 19 decimal support #21317
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
mroeschke:ref/cudf/decimal_simplfiy

Conversation

@mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Feb 3, 2026

Description

  • Use ColumnBase.create in ColumnBase.to_arrow to more reliably preserve dtype metadata
  • Follows up with Require pyarrow 19 or greater #21183 to eliminate more decimal32/64 special casing
    • Fixed a bug where ArrowDtype.to_arrow was still always returning a pa.Decimal128 object

The added tests to conftest-patch.py use "object" in the test body as pandas does not support a native decimal type. This is incongruent as we interpret object as string leading to incorrect results, which I think is becoming a defining different when using object in cuDF vs pandas

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Feb 3, 2026
@mroeschke mroeschke requested a review from a team as a code owner February 3, 2026 20:12
@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels Feb 3, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Feb 3, 2026
@mroeschke mroeschke added non-breaking Non-breaking change and removed improvement Improvement / enhancement to an existing function labels Feb 3, 2026
@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Feb 5, 2026
@vyasr vyasr changed the title Use ColumnBase.create in from_arrow, follow-ups in pyarrow 19 decimal support Use ColumnBase.create in from_arrow, follow-ups in pyarrow 19 decimal support Feb 6, 2026
@vyasr
Copy link
Contributor

vyasr commented Feb 6, 2026

/merge

@rapids-bot rapids-bot bot merged commit bc7710a into rapidsai:main Feb 6, 2026
114 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Feb 6, 2026
@mroeschke mroeschke deleted the ref/cudf/decimal_simplfiy branch February 6, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants