Ensure ColumnBase.create asserts that plc_column type is equivalent to passed dtype#21325
Merged
rapids-bot[bot] merged 6 commits intorapidsai:mainfrom Feb 6, 2026
Conversation
mroeschke
added
improvement
3 tasks
vyasr
approved these changes
Feb 6, 2026
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we have
ColumnBasesubclasses that can represent multiple types e.g.NumericalColumn.ColumnBase._validate_argsvalidates that the passeddtypeis a valid type for this column but currently we lack a check that the passeddtypeis an equivalent type to the passedplc_column.type(). #21320 is an example where we can end up in an invalid state if these mismatch.A follow up is to fortify this check for nested types to also validate the child types.
On top of #21324
Checklist