-
Notifications
You must be signed in to change notification settings - Fork 36
wheels CI: stricter torch index selection, test oldest versions of dependencies #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
974c79a
d705541
7e15156
43efc44
34b8853
25e4fd7
12ec8ca
7a5dd11
843296e
d246b1a
eb6be78
4e923d4
c054b60
29e1769
c39b7b1
fef3fe1
333d00b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -257,6 +257,7 @@ jobs: | |||
| build_type: pull-request | ||||
| script: ci/test_wheel_pylibwholegraph.sh | ||||
| matrix_filter: map(select(.ARCH == "amd64")) | ||||
| matrix_type: 'nightly' | ||||
| wheel-build-cugraph-pyg: | ||||
| needs: checks | ||||
| secrets: inherit | ||||
|
|
@@ -279,3 +280,4 @@ jobs: | |||
| build_type: pull-request | ||||
| script: ci/test_wheel_cugraph-pyg.sh | ||||
| matrix_filter: map(select(.ARCH == "amd64")) | ||||
| matrix_type: 'nightly' | ||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Revert before merging. |
||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -e -u -o pipefail | ||
|
|
||
| # Ensure CUDA-enabled 'torch' packages are always used. | ||
| # | ||
| # Downloading + adding the downloaded file to the constraint forces the use of this | ||
| # package, so we don't accidentally end up with a CPU-only 'torch' from 'pypi.org' | ||
| # (which can happen because --extra-index-url doesn't imply a priority). | ||
| rapids-logger "Downloading 'torch' wheel" | ||
| CUDA_MAJOR="${RAPIDS_CUDA_VERSION%%.*}" | ||
| if [[ "${CUDA_MAJOR}" == "12" ]]; then | ||
| PYTORCH_INDEX="https://download.pytorch.org/whl/cu126" | ||
| else | ||
| PYTORCH_INDEX="https://download.pytorch.org/whl/cu130" | ||
| fi | ||
|
|
||
| TORCH_WHEEL_DIR=$(mktemp -d) | ||
| pip download \ | ||
| --prefer-binary \ | ||
| --no-dps \ | ||
| --constraint "${PIP_CONSTRAINT}" \ | ||
| --index-url "${PYTORCH_INDEX}" \ | ||
| 'torch' | ||
|
|
||
| echo "torch @ file://$(echo ${TORCH_WHEEL_DIR}/torch_*.whl)" >> "${PIP_CONSTRAINT}" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -324,6 +324,10 @@ dependencies: | |
| - *cmake_ver | ||
| test_python_common: | ||
| common: | ||
| - output_types: [conda] | ||
| packages: | ||
| - torchdata | ||
| - pydantic | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just moving this here so This |
||
| - output_types: [conda, pyproject, requirements] | ||
| packages: | ||
| - pytest<9.0.0 | ||
|
|
@@ -343,14 +347,15 @@ dependencies: | |
| - pytest-forked | ||
| - scipy | ||
| depends_on_pytorch: | ||
| common: | ||
| - output_types: [conda] | ||
| packages: | ||
| - torchdata | ||
| - pydantic | ||
| specific: | ||
| - output_types: [requirements] | ||
| matrices: | ||
| # If 'include_torch_extra_index=false' is passed, avoid these --extra-index-url. | ||
| # (useful in CI scripts where we want to tightly which indices 'pip' uses). | ||
jameslamb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - matrix: | ||
| include_torch_extra_index: "false" | ||
| packages: | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This will only affect cases where So this should not break any other uses of this file. |
||
| # otherwise, choose a CUDA-version-specific index | ||
| - matrix: | ||
| cuda: "12.*" | ||
| packages: | ||
|
|
@@ -374,13 +379,27 @@ dependencies: | |
| - matrix: | ||
| packages: | ||
| - *pytorch_pip | ||
| - output_types: [requirements] | ||
| matrices: | ||
| - matrix: | ||
| cuda: "12.*" | ||
| dependencies: "oldest" | ||
| packages: | ||
| - torch==2.3 | ||
| - matrix: | ||
| cuda: "13.*" | ||
| dependencies: "oldset" | ||
jameslamb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| packages: | ||
| - torch==2.9.0 | ||
| - matrix: | ||
| packages: | ||
| - output_types: [conda] | ||
| matrices: | ||
| # Prevent fallback to CPU-only pytorch when we want a CUDA variant. | ||
| - matrix: | ||
| require_gpu: "true" | ||
| packages: | ||
| - pytorch-gpu | ||
| - pytorch-gpu >=2.3 | ||
| # Default to falling back to whatever 'pytorch' is pulled in via cugraph-pyg's dependencies. | ||
| - matrix: | ||
| packages: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert this. Just added here for testing, to confirm this will fix the issues we've been seeing in nightlies.