Open
Conversation
Contributor
Greptile SummaryThis PR makes defensive null-check improvements to the WholeGraph bindings:
The changes are safe for merging — no blocking issues identified. Confidence Score: 5/5
Last reviewed commit: 18054d8 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+427
to
+429
| if global_context == NULL: | ||
| (<void **> memory_context)[0] = NULL | ||
| return |
Contributor
There was a problem hiding this comment.
memory_context is dereferenced at line 428 without first checking for null. When global_context == NULL, the code writes to memory_context[0] without validating memory_context itself is non-null. Every other callback in this PR (destroy, malloc, free, output_malloc, output_free) guards against null memory_context before dereferencing. This should be consistent:
Suggested change
| if global_context == NULL: | |
| (<void **> memory_context)[0] = NULL | |
| return | |
| if global_context == NULL: | |
| if memory_context != NULL: | |
| (<void **> memory_context)[0] = NULL | |
| return |
Contributor
|
/ok to test 64d68c3 |
Contributor
|
/ok to test 18054d8 |
Contributor
|
Looks like this did fix the first round of segfaults. I added a 3.14 test job for Currently: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.