Update Treelite to 4.7.0#7870
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughTreelite minimum version was raised from 4.6.1 to 4.7.0 across dependency manifests and build configs; the Treelite Git tag and VERSION were also updated in the CMake retrieval script. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dependencies.yaml`:
- Line 319: The Treelite version is bumped to >=4.7.0 in dependencies.yaml but
cpp/cmake/thirdparty/get_treelite.cmake still pins VERSION 4.6.1; update the
CMake fetch to use VERSION 4.7.0 (replace the VERSION value and any
corresponding URL/checksum constants in get_treelite.cmake), ensure any
variables or comments referencing 4.6.1 are updated, and run the CMake fetch
step locally to verify the source URL/checksum remain correct and builds
succeed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8059b1a7-715a-44a3-b043-a68f50ce3d6a
📒 Files selected for processing (8)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-131_arch-aarch64.yamlconda/environments/all_cuda-131_arch-x86_64.yamlconda/recipes/cuml/conda_build_config.yamlconda/recipes/libcuml/conda_build_config.yamldependencies.yamlpython/cuml/pyproject.toml
|
Retargeting this pull request to the 26.04 branch. |
|
The OOM failure you're seeing in the sklearn tests is the one that #7881 (cherry-picked back to this branch) will/should fix. |
|
/merge |
abc17be
into
rapidsai:release/26.04
Update Treelite to 4.7.0 to incorporate the following improvements: